Project

General

Profile

Actions
Copy link

Feature #3131

closed

Remove unneeded connection bsd filter handling for OpenBSD

Added by devnexen almost 3 years ago. Updated almost 3 years ago.

Status:
Fixed
Priority:
Low
Category:
core
Target version:
1.4.64
ASK QUESTIONS IN Forums:
No

Description

- Just a little nit ; OpenBSD is the only main BSD not supporting accept filter on sockets.
- Edited from master branch.

Files

0001-remove-unneeded-connection-accept-filter-for-OpenBSD.patch (973 Bytes) 0001-remove-unneeded-connection-accept-filter-for-OpenBSD.patch devnexen, 2022-01-03 16:35
Actions
Copy link
 #1

Updated by gstrauss almost 3 years ago

Why was this filed as a bug? What is the impact?

If OpenBSD does not define SO_ACCEPTFILTER, then the rest of the code in that code block does not exist.

Actions
Copy link
 #2

Updated by devnexen almost 3 years ago

Because it is not a new feature.

Thinking of it maybe surrounding the whole block by SO_ACCEPTFILTER instead of those BSD constants would be better ?

Actions
Copy link
 #3

Updated by gstrauss almost 3 years ago

  • Category set to core
  • Status changed from New to Invalid
  • Priority changed from Normal to Low

What is the impact?

Impact is zero. Modern compiler optimizers will remove the empty code block on OpenBSD, as buffer_is_equal_string is defined to buffer_eq_slen, which is marked __attribute__(__pure__) in buffer.h.

A bug has a negative impact. If it is not a bug, you can mark it as a feature, not the other way around.

Actions
Copy link
 #4

Updated by gstrauss almost 3 years ago

  • Target version deleted (1.4.xx)
Actions
Copy link
 #5

Updated by gstrauss almost 3 years ago

  • Tracker changed from Bug to Feature
  • Status changed from Invalid to Patch Pending
  • Target version set to 1.4.64
Actions
Copy link
 #6

Updated by gstrauss almost 3 years ago

  • Status changed from Patch Pending to Fixed
Actions
Copy link

Also available in: Atom