Project

General

Profile

Actions

Bug #3133

closed

netbsd meson build fix

Added by devnexen 9 months ago. Updated 9 months ago.

Status:
Fixed
Priority:
Normal
Category:
build_cmake
Target version:
ASK QUESTIONS IN Forums:
No

Description

- this is a pure meson issue, cmake and autoconf builds work fine.
- mostly little misdetections.
- patch done out of personal/gstrauss/master branch.


Files

Actions #1

Updated by devnexen 9 months ago

note that openbsd ought to have same cases :
- no mempcpy support.
- crypt having same header https://man.openbsd.org/crypt.3
- even less libdl support.

Actions #2

Updated by gstrauss 9 months ago

  • Category set to build_cmake
  • Status changed from New to Patch Pending
  • Target version changed from 1.4.xx to 1.4.64

Turns out there are some issues with meson detection and confusion with builtins, which for some compilers are always provided, even when not present on a platform. The workaround appears to be to use prefix with an include:
https://github.com/mesonbuild/meson/issues/3672
conf_data.set('HAVE_MEMPCPY', compiler.has_function('mempcpy', args: defs, prefix: '#include <string.h>')

If that is not enough, then this might be:
conf_data.set('HAVE_MEMPCPY', compiler.has_function('mempcpy', args: defs, prefix: '#include <string.h>') and compiler.has_header_symbol('string.h', 'mempcpy', args: defs))

As for libdl, some systems such as NetBSD and OpenBSD have dlopen in libc, not libdl so the meson build fix is to avoid making presence of libdl a requirement.

Actions #3

Updated by devnexen 9 months ago

your fix works for me

Actions #4

Updated by gstrauss 9 months ago

  • Status changed from Patch Pending to Fixed
Actions

Also available in: Atom