Bug #1905

mod_simple_vhost default host not working

Added by jbittel about 5 years ago. Updated about 5 years ago.

Status:FixedStart date:2009-02-17
Priority:NormalDue date:
Assignee:-% Done:

100%

Category:mod_simple_vhost
Target version:1.4.22
Missing in 1.5.x:

Description

I recently installed 1.4.21 on one of my servers that uses mod_simple_vhost and immediately the default host stopped working. All requests that should have used that field returned a 404. I reverted r2322 and immediately it began working correctly again. The problem seems to be caused by the fact that the return added in r2322 is causing the physical.doc_root to not get updated. I replicated the the buffer copy call to update the physical.doc_root into the default host fallback else branch, and it appears to have resolved the problem.

I've attached a patch that shows the one line that I changed. There may be a cleaner way to fix it, but I've been running this on my server and so far it's behaving as expected.

simple-vhost-patch (455 Bytes) jbittel, 2009-02-17 22:36

Associated revisions

Revision 2399
Added by stbuehler about 5 years ago

Fix default vhost in mod_simple_vhost (fixes #1905)

History

#1 Updated by stbuehler about 5 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

Applied in changeset r2399.

Also available in: Atom