Project

General

Profile

Bug #2025

mod_geoip crashes lighttpd 1.5.x on FreeBSD 7.2 AMD64

Added by flackman almost 8 years ago. Updated 8 months ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
2009-07-10
Due date:
% Done:

0%

Missing in 1.5.x:

Description

The backtrace will look something like this:

#0  0x0000000801809660 in _GeoIP_addr_to_num () from /usr/local/lib/libGeoIP.so.5

Looking further into this, this function is passed the addr from mod_geoip.c:228:

                            remote_ip = inet_ntop_cache_get_ip(srv, &(con->dst_addr));

remote_ip here is what is passed to the above function that fails. I am not quite sure why we are calling inet_ntop_cache_get_ip() since this is already called in connections.c, and the dst_addr_buf field is populated with the results. Changing the above line (mod_geoip.c:228) to:

                            remote_ip = con->dst_addr_buf->ptr;

fixes this and saves a few cycles. There may be a similar problem in mod_trigger_b4_dl, but I do not use that module.


Related issues

Related to Bug #1938: lighttpd 1.4 crashes on FreeBSD 7.0 AMD64 when mod_geoip is compiled in Fixed 2009-03-17

Associated revisions

Revision 5dfe21ac (diff)
Added by gstrauss 8 months ago

[mod_geoip] add to default build (fixes #2705, fixes #2101, fixes #2092, fixes #2025, fixes #1962, fixes #1938)

(add to default build to reduce distributor package maintenance)

x-ref:
"broken module API since 1.4.38"
https://redmine.lighttpd.net/issues/2705
"lighttpd-1.4.24 fails to compile with mod_geoip.c"
https://redmine.lighttpd.net/issues/2101
"unsafe sprintfs mod_geoip"
https://redmine.lighttpd.net/issues/2092
"mod_geoip crashes lighttpd 1.5.x on FreeBSD 7.2 AMD64"
https://redmine.lighttpd.net/issues/2025
"mod_geoip"
https://redmine.lighttpd.net/issues/1962
"lighttpd 1.4 crashes on FreeBSD 7.0 AMD64 when mod_geoip compiled in"
https://redmine.lighttpd.net/issues/1938

History

#3 Updated by gstrauss about 1 year ago

#4 Updated by stbuehler about 1 year ago

  • Status changed from New to Invalid
  • Target version deleted (1.5.0)

3rd party module.

#5 Updated by gstrauss 8 months ago

  • Related to Bug #1938: lighttpd 1.4 crashes on FreeBSD 7.0 AMD64 when mod_geoip is compiled in added

#6 Updated by gstrauss 8 months ago

  • Target version set to 1.4.42

#7 Updated by gstrauss 8 months ago

  • Status changed from Invalid to Fixed

Also available in: Atom