Project

General

Profile

Bug #2705

broken module API since 1.4.38

Added by pkubaj over 1 year ago. Updated 11 months ago.

Status:
Fixed
Priority:
Normal
Assignee:
-
Category:
-
Target version:
Start date:
2016-01-03
Due date:
% Done:

0%

Estimated time:
Missing in 1.5.x:

Description

Compiling external modules, e.g. mod_geoip fails with:
mod_geoip.c:148:101: error: too few arguments to function call, expected 4, have 3
if (0 != config_insert_values_global(srv, ((data_config *)srv->config_context->data[i])->value, cv)) {

This happens on FreeBSD 10.2-RELEASE with Clang 3.4.1. I can write a patch myself, but I need to know what I should put in config_insert_values_global, so that running it doesn't change anything.

Associated revisions

Revision 5dfe21ac (diff)
Added by gstrauss 11 months ago

[mod_geoip] add to default build (fixes #2705, fixes #2101, fixes #2092, fixes #2025, fixes #1962, fixes #1938)

(add to default build to reduce distributor package maintenance)

x-ref:
"broken module API since 1.4.38"
https://redmine.lighttpd.net/issues/2705
"lighttpd-1.4.24 fails to compile with mod_geoip.c"
https://redmine.lighttpd.net/issues/2101
"unsafe sprintfs mod_geoip"
https://redmine.lighttpd.net/issues/2092
"mod_geoip crashes lighttpd 1.5.x on FreeBSD 7.2 AMD64"
https://redmine.lighttpd.net/issues/2025
"mod_geoip"
https://redmine.lighttpd.net/issues/1962
"lighttpd 1.4 crashes on FreeBSD 7.0 AMD64 when mod_geoip compiled in"
https://redmine.lighttpd.net/issues/1938

History

#1 Updated by stbuehler over 1 year ago

  • Status changed from New to Invalid

How about searching for how all the other modules are calling it? And maybe also have a look at the commit changing it?

#2 Updated by gstrauss over 1 year ago

I uploaded a patch to https://redmine.lighttpd.net/projects/lighttpd/wiki/Docs_ModGeoip which applies to mod_geoip_for_1.4.c (rename to mod_geoip.c) in order to compile mod_geoip.c cleanly under lighttpd 1.4.39. (I have not tested beyond compiling it.)

#3 Updated by gstrauss 11 months ago

  • Target version set to 1.4.42

#4 Updated by gstrauss 11 months ago

  • Status changed from Invalid to Fixed

Also available in: Atom