Project

General

Profile

Actions

Feature #1119

closed

Add $HTTP["language"] for config conditionals based on `Accept-Language'.

Added by petar over 14 years ago. Updated over 5 years ago.

Status:
Obsolete
Priority:
Normal
Category:
core
Target version:
ASK QUESTIONS IN Forums:

Description

With the attached patch, one should be able to redirect clients based on their `Accept-Language' request-header. This is a good thing for cgi-less multilingual sites.


Files

language.patch (3.3 KB) language.patch petar, 2007-04-13 19:05
language.2.patch (2.62 KB) language.2.patch readjusted for 1.4.19 -- petar Anonymous, 2008-05-09 15:33
language.3.patch (2.62 KB) language.3.patch language.2.patch wasn't uploaded properly -- petar Anonymous, 2008-05-09 15:35
lang.diff (2.62 KB) lang.diff Accept-Language patch for lighttpd 1.4.20. -- petar Anonymous, 2008-10-08 12:25
Actions #1

Updated by darix over 14 years ago

i think this is most likely something for 1.5 not for 1.4. jan?:)

Actions #2

Updated by petar over 14 years ago

Just for the record: I applied the patch on a productive lighttpd-1.4.13, the language-related config-section looks something like..


$HTTP["host"] =~ "^www\.site\.net$" {
        $HTTP["language"] =~ "(de|it|hr)" {
                url.redirect = ( "^/$" => "http://www.site.net/%1/" )
        }
        else $HTTP["language"] =~ ".*" {
                url.redirect = ( "^/$" => "http://www.site.net/en/" )
        }
}

..and the whole thing works quite well.

Actions #3

Updated by Anonymous over 13 years ago

There is something wrong with the attachment viewer. Raw file downloads work, but the viewer just displays a part of the file.

-- petar

Actions #4

Updated by stbuehler about 13 years ago

  • Target version changed from 1.4.20 to 1.4.21
Actions #5

Updated by icy over 12 years ago

  • Target version changed from 1.4.21 to 1.4.22
  • Patch available set to Yes
Actions #6

Updated by petar over 12 years ago

Just FYI: I'm carrying this patch since 1.4.18 (or even 1.4.16) and never had any problems.

Petar

Actions #7

Updated by icy over 12 years ago

petar wrote:

Just FYI: I'm carrying this patch since 1.4.18 (or even 1.4.16) and never had any problems.

Thanks for the heads up. I'll ask if we can have this included in .21 too because it is lingering around for such a long time now but I'm not sure if we will do that as we want to get .21 out really really soon.

Actions #8

Updated by stbuehler over 12 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

Applied in changeset r2392.

Actions #9

Updated by petar over 12 years ago

Thank you!

Actions #10

Updated by a3nm about 9 years ago

  • Status changed from Fixed to Reopened
  • Target version changed from 1.4.22 to 1.5.0

Not sure at all if this is the right way to complain about this (apologies if it isn't), but this useful feature has apparently not been ported to the 1.5x branch. Is it possible/desirable to do so?

Thanks!

Actions #11

Updated by gstrauss over 5 years ago

  • Assignee deleted (jan)
  • Missing in 1.5.x set to Yes

FYI: patch was applied in lighttpd 1.4.x a long time ago

Actions #12

Updated by gstrauss over 5 years ago

  • Status changed from Reopened to Obsolete
Actions

Also available in: Atom