Lighttpd

I think that is cheating with the system headers.. imho we should include "config.h" always before any other (system) header.

But you could try to replace _LARGEFILE_SOURCE with _LARGEFILE64_SOURCE in the #if defined [...] line for sendfile.

@Markus, it would be more consistent for your build if you edited config.h and commented out the define of _GNU_SOURCE

@stbuehler wrote:

imho we should include "config.h" always before any other (system) header.

Would you please be more specific about what you'd like to see for including config.h before other system headers?
Do you mean #include config.h" at the beginning of every src/*.c and src/*.y? It seems like this is straightforward to do, so I'll prepare a patch once a convention is chosen.

Hm. I think including a "first.h" header, which then includes "config.h" if it is available and defines the features macros _GNU_SOURCE and __USE_GNU (from settings.h) would be a good start. This shouldn't break anything even in the "external sources" like lempar, lemon and splaytree.

Submitted pull request https://github.com/lighttpd/lighttpd1.4/pull/41

• added missing include guards in md5.h and proc_open.h
• fixed md5.h to get proper definition for USE_OPENSSL
  (now uses openssl MD5 routines, where available; never did so before)
• added #include "first.h" after include guards to *.h
  (could have been scripted, but instead manually reviewed for consistency)
  (e.g. see the header file fixes above)
• added #include "first.h" to *.c using:
  

    perl -pi -e 'BEGIN { $/ = undef; } s/\A/#include "first.h"\n\n/s' *.c
  

• adjusted #include "first.h" in lempar.c (template for code generated from .y)
• removed #include "first.h" from splaytree.c (third-party)
• created first.h where config.h is included and _GNU_SOURCE is defined
• removed #include "config.h" from *.[ch]
• removed unused defines in settings.h

note:
on some platforms, might need to update build files to link modules using md5.[ch] with openssl (or disable my changes above which use openssl MD5 when available).