Lighttpd

Trivial patch, but the question is whether it should be done or not. Also, should something similar be done in mod_rewrite?

mod_rewrite documents:
https://redmine.lighttpd.net/projects/lighttpd/wiki/docs_modrewrite

However, mod_rewrite provides a mechanism to pass URLs through unmangled: specify "$0" as the rule target.

Updated patch to match target pattern against "$0" and short-circuit since it is 'identity' pattern, similar to mod_rewrite.

diff --git a/src/mod_redirect.c b/src/mod_redirect.c
index 5e99dcb..d79403e 100644
--- a/src/mod_redirect.c
+++ b/src/mod_redirect.c
@@ -209,6 +209,10 @@ static handler_t mod_redirect_uri_handler(server *srv, connection *con, void *p_
                                                "execution error while matching: ", n);
                                return HANDLER_ERROR;
                        }
+               } else if (2 == pattern_len && pattern[0] == '$' && pattern[1] == '0') {
+                       /* short-circuit if "$0" replacement pattern (identity)
+                        * (do not attempt to match against remaining redirect rules) */
+                       return HANDLER_GO_ON;
                } else {
                        const char **list;
                        size_t start;

gstrauss wrote:

mod_rewrite documents:
https://redmine.lighttpd.net/projects/lighttpd/wiki/docs_modrewrite

However, mod_rewrite provides a mechanism to pass URLs through unmangled: specify "$0" as the rule target.

That is actually not true (don't know who wrote that piece): "$0" is the complete match, but if you didn't match the complete input, it doesn't return the "unmangled" input.

Does that mean you would prefer the solution originally presented, which is a blank target pattern?

A blank target doesn't have any sane semantic so far, so I see no problem using it for a special purpose. Maybe the same pattern could then also be applied to mod_rewrite for consistency.

Thanks.
Simple modification to the patch. I'll look at mod_rewrite next.

diff --git a/src/mod_redirect.c b/src/mod_redirect.c
index 5e99dcb..d79403e 100644
--- a/src/mod_redirect.c
+++ b/src/mod_redirect.c
@@ -209,6 +209,10 @@ static handler_t mod_redirect_uri_handler(server *srv, connection *con, void *p_
                                                "execution error while matching: ", n);
                                return HANDLER_ERROR;
                        }
+               } else if (0 == pattern_len) {
+                       /* short-circuit if blank replacement pattern
+                        * (do not attempt to match against remaining redirect rules) */
+                       return HANDLER_GO_ON;
                } else {
                        const char **list;
                        size_t start;

Similar change to add this feature to mod_rewrite:

diff --git a/src/mod_rewrite.c b/src/mod_rewrite.c
index fac6c49..faa7f84 100644
--- a/src/mod_rewrite.c
+++ b/src/mod_rewrite.c
@@ -383,6 +383,10 @@ static handler_t process_rewrite_rules(server *srv, connection *con, plugin_data
                                                "execution error while matching: ", n);
                                return HANDLER_ERROR;
                        }
+               } else if (0 == pattern_len) {
+                       /* short-circuit if blank replacement pattern
+                        * (do not attempt to match against remaining rewrite rules) */
+                       return HANDLER_GO_ON;
                } else {
                        const char **list;
                        size_t start;