Project

General

Profile

Actions

Bug #2115

closed

Issue in the parsing of filetypes for mod_compress

Added by elvanor almost 12 years ago. Updated almost 12 years ago.

Status:
Duplicate
Priority:
Normal
Category:
-
Target version:
-
ASK QUESTIONS IN Forums:

Description

If I have the following:

compress.filetype  = ("text/plain", "text/css", "text/javascript", "text/html")

and

".js" => "text/javascript; charset=utf-8",

in mime-types.conf, then the file won't be sent compressed, because the charset=utf-8 prevents the parser, which does a simple string comparison, to recognize it as a valid filetype.

If I change to:

compress.filetype  = ("text/plain", "text/css", "text/javascript; charset=utf-8", "text/html")

it works.

This should probably be fixed, although it could have performance implications


Related issues

Is duplicate of Bug #1552: mod_compress: should match for complete mime-type and the part before ';'FixedjanActions
Actions #1

Updated by elvanor almost 12 years ago

I just noticed that this fact is documented in the Wiki... so the developers maybe do not want to fix this issue.

Actions #2

Updated by darix almost 12 years ago

as mentioned on irc already. parsing the mime type string could in worst case lead to looping through the compress.filetype array twice. so there could be a performance impact. (small one though)

Actions #3

Updated by stbuehler almost 12 years ago

  • Status changed from New to Duplicate

Already implemented. Always specify the version you tried...

Actions

Also available in: Atom