Project

General

Profile

Actions
Copy link

Bug #2238

closed

Build alters src files

Added by Olaf-van-der-Spek over 14 years ago. Updated over 1 year ago.

Status:
Obsolete
Priority:
Normal
Category:
build_autotools
Target version:
-
ASK QUESTIONS IN Forums:
No

Description

Could this be moved out of the build process?

$ grep 144 src/configparser.c 
#line 144 "../../src/configparser.y" 
#line 1144 "configparser.c" 

$ make

$ grep 144 src/configparser.c 
#line 144 "./configparser.y" 
#line 1144 "configparser.c"

Related issues 1 (0 open — 1 closed)

Related to Bug #2244: rev 2748 broke src/MakefileDuplicate2010-08-09Actions
Actions
Copy link
 #1

Updated by stbuehler over 14 years ago

If you don't want to alter files in the src directory you should build in a special build subdirectory, like

mkdir build
cd build
../configure ....
make

Actions
Copy link
 #2

Updated by Olaf-van-der-Spek over 14 years ago

I'll try. Can't this be avoided completely though?

Actions
Copy link
 #3

Updated by stbuehler over 14 years ago

  • Status changed from New to Fixed
Actions
Copy link
 #4

Updated by stbuehler over 14 years ago

  • Status changed from Fixed to Reopened

Ah yes, now i remember what the problem was (See #2244):

rev 2748 broke src/Makefile with BSD make.
make all-recursive
Making all in src
make: don't know how to make |. Stop in /usr/ports/www/lighttpd/w-lighttpd-1.4.27/lighttpd-1.4.27/src.
  • Error code 1

I'm not sure what is more important for me, but i think i think we should go for make compatibility.

Actions
Copy link
 #5

Updated by Olaf-van-der-Spek over 14 years ago

Why does recreating them result in different file contents?
Isn't it possible to include the final version in your VCS?

Actions
Copy link
 #6

Updated by stbuehler over 14 years ago

I make the distbuild in a "distbuild/" subdirectory; so the relative path, which is what lemon writes into the parser files, is "../../src/" instead of "./".

If you want you can propose a patch for lemon to remove the path in the #line output.

And no, we don't include auto-generated files in the VCS; it would make diffs pretty annoying to read.

Actions
Copy link
 #7

Updated by stbuehler over 14 years ago

  • Status changed from Reopened to Wontfix
  • Target version deleted (1.4.27)

I will revert the commit #2748, and i'll set this to wontfix (i.e. i don't have the time to modify lemon.c). Feel free to reopen if you can provide a good patch.

Actions
Copy link
 #8

Updated by gstrauss over 1 year ago

  • Status changed from Wontfix to Obsolete
  • ASK QUESTIONS IN Forums set to No

In lighttpd 1.4.69, the LEMON parser was updated to the version maintained in SQLite.

lighttpd build systems (autoconf, CMake, SCons, meson) support building in alternate build directories.

Actions
Copy link

Also available in: Atom