Project

General

Profile

Actions

Bug #2238

closed

Build alters src files

Added by Olaf-van-der-Spek almost 12 years ago. Updated almost 12 years ago.

Status:
Wontfix
Priority:
Normal
Category:
build_autotools
Target version:
-
ASK QUESTIONS IN Forums:

Description

Could this be moved out of the build process?

$ grep 144 src/configparser.c 
#line 144 "../../src/configparser.y" 
#line 1144 "configparser.c" 

$ make

$ grep 144 src/configparser.c 
#line 144 "./configparser.y" 
#line 1144 "configparser.c" 

Related issues

Related to Bug #2244: rev 2748 broke src/MakefileDuplicate2010-08-09Actions
Actions #1

Updated by stbuehler almost 12 years ago

If you don't want to alter files in the src directory you should build in a special build subdirectory, like

mkdir build
cd build
../configure ....
make

Actions #2

Updated by Olaf-van-der-Spek almost 12 years ago

I'll try. Can't this be avoided completely though?

Actions #3

Updated by stbuehler almost 12 years ago

  • Status changed from New to Fixed
Actions #4

Updated by stbuehler almost 12 years ago

  • Status changed from Fixed to Reopened

Ah yes, now i remember what the problem was (See #2244):

rev 2748 broke src/Makefile with BSD make.
make all-recursive
Making all in src
make: don't know how to make |. Stop in /usr/ports/www/lighttpd/w-lighttpd-1.4.27/lighttpd-1.4.27/src.
  • Error code 1

I'm not sure what is more important for me, but i think i think we should go for make compatibility.

Actions #5

Updated by Olaf-van-der-Spek almost 12 years ago

Why does recreating them result in different file contents?
Isn't it possible to include the final version in your VCS?

Actions #6

Updated by stbuehler almost 12 years ago

I make the distbuild in a "distbuild/" subdirectory; so the relative path, which is what lemon writes into the parser files, is "../../src/" instead of "./".

If you want you can propose a patch for lemon to remove the path in the #line output.

And no, we don't include auto-generated files in the VCS; it would make diffs pretty annoying to read.

Actions #7

Updated by stbuehler almost 12 years ago

  • Status changed from Reopened to Wontfix
  • Target version deleted (1.4.27)

I will revert the commit #2748, and i'll set this to wontfix (i.e. i don't have the time to modify lemon.c). Feel free to reopen if you can provide a good patch.

Actions

Also available in: Atom