Feature #2315: dir-listing.external-js - Lighttpd - lighty labs

Actions

Copy link

Feature #2315

closed

dir-listing.external-js

Added by molyland over 13 years ago. Updated about 8 years ago.

Status:

Fixed

Priority:

Normal

Category:

mod_dirlisting

Target version:

1.4.42

ASK QUESTIONS IN Forums:

Description

Append option to dir-listing module to import a javascript external file in the dir-listing default html page.
For example: <script type="text/javascript" src="script.js"></script>.
This patch is append to release 1.4.28

Files

Download all files

mod_dirlisting.c (25.9 KB) mod_dirlisting.c		molyland, 2011-05-12 11:18
mod_dirlisting_patch.txt (5.83 KB) mod_dirlisting_patch.txt		molyland, 2011-11-16 11:12

Related issues 1 (0 open — 1 closed)

Actions

Copy link

Updated by molyland over 13 years ago

Assignee deleted (~~molyland~~)
% Done changed from 0 to 100

Actions

Copy link

Updated by ghost_1987 almost 13 years ago

Status changed from New to Patch Pending

Please add this feature into official source tree for the next release

Actions

Copy link

Updated by spaam almost 13 years ago

thats not a patch.. run svn diff and send us the output from that command.
svn diff > adding_external_js.patch or something.

Actions

Copy link

Updated by molyland almost 13 years ago

File mod_dirlisting_patch.txt mod_dirlisting_patch.txt added

This is the proposed patch for mod_dirlisting.c (changeset 2799)

Actions

Copy link

Updated by stbuehler almost 13 years ago

Don't renumber the options.

Actions

Copy link

Updated by gstrauss over 8 years ago

Related to Feature #613: client-selectable directory list sorting, patch included added

Actions

Copy link

Updated by gstrauss over 8 years ago

Status changed from Patch Pending to Need Feedback

A directive dir-listing.head-insert would be more generic. It would be similar to IndexHeadInsert from Apache 2.4 which inserts an configured string into head section.

I realize that your patch modeled off of dir-listing.external-css. The reason dir-listing.external-css can not be fold into a more generic dir-listing.head-insert is that if dir-listing.external-css is not specified, then mod_dirlisting provides a default CSS.

Note: this would only be enabled if dir-listing.auto-layout = "enable" (which is the default)

(and when updating this patch, please also read the previous feedback instructing not to renumber the options)

Actions

Copy link