Lighttpd

I second that!

-- nixin

I've created a patch against lighttpd 1.4.18 for this

The patch seems to work perfectly. Thanks a lot !

Please consider including it as default for the future versions of lighty.

-- wolfy

stbuehler wrote:

I'd prefer client side sorting via javascript; see our dirlist module for 2.0 (http://cgit.lighttpd.net/lighttpd/sandbox/plain/src/modules/mod_dirlist.c, demo here: http://download.lighttpd.net/lighttpd/).

this does not work on IE8 and older

please consider adding sorting feature as provided by the patch

FYI: IE 8 is no longer supported on mainstream OS, so a client-side sort in javascript is now a more reasonable solution.
https://support.microsoft.com/en-us/lifecycle/search?sort=PN&alpha=internet%20explorer
https://support.microsoft.com/en-us/lifecycle#gp/Microsoft-Internet-Explorer

I think you want to move the parsing of the query-string from http_list_directory to mod_dirlisting_response, and then pass sort and sort_dir into http_list_directory_header and http_list_directory.

Do your changes to http_list_directory_header to create hrefs break javascript sorting?

Your changes to http_list_directory_header hard-code magic numbers. I think you want to use preprocessor directive ## to paste token stringification (#) strings instead of hard-coding the magic numbers.

While it might be cleaner to pass to http_dirls_sort a function pointer to a comparator function, it will probably be faster without too much extra code to specialize http_dirls_sort for each of the 6 combinations. (And possibly more clever to sort as 3 combinations ascending, and to read the list backwards if descending sorting was desired.) Then again, the existing patch could reduce code duplication with something like (untested)

off_t res =
  type == SORT_ALPHA
  ? strcmp(DIRLIST_ENT_NAME(ent[i]), DIRLIST_ENT_NAME(ent[j]))
  : type == SORT_MODIFIED ? ent[i]->mtime - ent[j]->mtime
  : /*(type == SORT_SIZE)*/ ent[i]->size  - ent[j]->size;
if ((dir == SORT_DIR_ASC ? res : -res) > 0) {
        tmp = ent[i];
        ent[i] = ent[j];
        ent[j] = tmp;
        swapped = 1;
}