Project

General

Profile

Actions

Feature #2352

closed

Send Last-Modified header when sendfile is used

Added by Olaf-van-der-Spek over 13 years ago. Updated over 1 year ago.

Status:
Fixed
Priority:
Normal
Category:
core
Target version:
-
ASK QUESTIONS IN Forums:
No

Description

Could Lighttpd send the Last-Modified header when sendfile is used, like it does for normal static files?

Actions #1

Updated by stbuehler over 13 years ago

  • Status changed from New to Invalid
  • Target version deleted (1.4.30)

I'm pretty sure this is totally unrelated.

Actions #2

Updated by Olaf-van-der-Spek over 13 years ago

I meant the X-Sendfile FastCGI header. Not sendfile().

Actions #3

Updated by stbuehler over 13 years ago

ah. well, still no.

mod_staticfile only sends last-modified if it found a mimetype; not finding a mimetype defaults to application/octet-stream, but will disable the last-modified header.
as we don't search for mimetypes in x-sendfile, there shouldn't be last-modified either; both can be send from the backend.

Actions #4

Updated by Olaf-van-der-Spek over 13 years ago

The backend might not know when the file was last modified. Even if it does, you'd then also have to duplicate the If-Modifies-Since checks, which is non-trivial.

Isn't not sending a Last-Modified header just a work around for some silly browsers?

Actions #5

Updated by Olaf-van-der-Spek over 13 years ago

Stefan?
ETag support is related too I think.

Actions #6

Updated by stbuehler over 13 years ago

  • Status changed from Invalid to Wontfix

If it makes you happy i can change it from Invalid to Wontfix. I'm not working on 1.5, and i doubt i have the time to review such patch for 1.4.x, and i certainly won't write it.

Actions #7

Updated by Olaf-van-der-Spek over 13 years ago

What about 2.0?

Actions #8

Updated by stbuehler over 13 years ago

wrong bugtracker, and feel free to extend the lua script we have right now.

Actions #9

Updated by Olaf-van-der-Spek over 13 years ago

stbuehler wrote:

wrong bugtracker, and feel free to extend the lua script we have right now.

Where's the 2.0 tracker?

Actions #10

Updated by gstrauss over 1 year ago

  • Category set to core
  • Status changed from Wontfix to Fixed
  • ASK QUESTIONS IN Forums set to No

Fixed in lighttpd 1.4.40.

Actions

Also available in: Atom