Project

General

Profile

Actions
Copy link

Bug #3043

closed

cert-staple.sh not POSIX compatible

Added by flynn 4 months ago. Updated 4 months ago.

Status:
Fixed
Priority:
Normal
Category:
TLS
Target version:
1.4.57
ASK QUESTIONS IN Forums:
No

Description

I tried to configure OCSP and found, that the provided script doc/scripts/cert-staple.sh does not run with the Debian standard shell due to bashisms.

Either the shebang of the script should be changed to 

#!/bin/bash
or made POSIX compatible (see attached patch).

Files

cert-staple.sh.diff (2.63 KB) cert-staple.sh.diff Changes from shellcheck run to fix POSIX issues flynn, 2020-12-03 06:25
Actions
Copy link
 #1

Updated by gstrauss 4 months ago

Ah, I think you are referring to the stunted cripple that is /bin/dash.

I'll probably change the shebang line. As much as I am a fan of the standards, I will probably conclude that this instance falls into the same category as POSIX_ME_HARDER.

Thanks for the report.

Actions
Copy link
 #2

Updated by flynn 4 months ago

I just used shellcheck and fixed most of the issues.

Actions
Copy link
 #3

Updated by stbuehler 4 months ago

The diff looks reasonable to me; there is zero need for the bash-style "tests" and the quoting looks fine.

Actions
Copy link
 #4

Updated by gstrauss 4 months ago

  • Status changed from New to Patch Pending
Actions
Copy link
 #5

Updated by gstrauss 4 months ago

  • Status changed from Patch Pending to Fixed
Actions
Copy link

Also available in: Atom