Project

General

Profile

Actions
Copy link

Bug #2233

closed

C99-ism in the code of mod_accesslog

Added by brad@comstyle.com over 14 years ago. Updated over 14 years ago.

Status:
Fixed
Priority:
Normal
Category:
mod_accesslog
Target version:
1.4.27
ASK QUESTIONS IN Forums:

Description

The mod_accesslog code has a C99-ism in it. The attached patch fixes the code.

Files

patch-src_mod_accesslog_c.diff (713 Bytes) patch-src_mod_accesslog_c.diff brad@comstyle.com, 2010-07-06 15:31
Actions
Copy link
 #1

Updated by Olaf-van-der-Spek over 14 years ago

What's wrong with using C99 features?

Actions
Copy link
 #2

Updated by brad@comstyle.com over 14 years ago

Olaf-van-der-Spek wrote:

What's wrong with using C99 features?

It would be nice if the code actually compiled and there is no C99 code anywhere else in the lighttpd codebase and similar issues have been fixed in the past.

Actions
Copy link
 #3

Updated by brad@comstyle.com over 14 years ago

Olaf-van-der-Spek wrote:

What's wrong with using C99 features?

It isn't much of a "feature" to make the code uglier.

Anyway, the same issue was fixed in src/response.c...

http://redmine.lighttpd.net/projects/lighttpd/repository/revisions/2721

Actions
Copy link
 #4

Updated by Olaf-van-der-Spek over 14 years ago

wrote:

It would be nice if the code actually compiled and there is no C99 code anywhere else in the lighttpd codebase and similar issues have been fixed in the past.

It does compile, AFAIK.
Why do C99 features result in ugly code?

Actions
Copy link
 #5

Updated by stbuehler over 14 years ago

  • Status changed from New to Fixed
  • % Done changed from 0 to 100

Applied in changeset r2743.

Actions
Copy link

Also available in: Atom