Bug #533

CACHE_MISS is unavailable in cml files

Added by Anonymous almost 9 years ago. Updated almost 6 years ago.

Status:FixedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:mod_cml
Target version:-
Missing in 1.5.x:

Description

I tried to use mod_cml, but failed when I used CACHE_MISS and CACHE_HIT. I succeeded when I use 0 or 1 for return values.

The reason is that CACHE_* are boolean values but the return value is assumed as a number. In my environment (lua 5.0.2), lua_tonumber checks the type of specified variable, and returns 0 (==CACHE_HIT) if the specified valiable does not keep number. Therefore, cache-miss never occurs if CACHE_* are used.

IMO, lua_pushnumber should be used for CACHE_*, instead of lua_pushboolean.

-- mukai

Associated revisions

Revision 2398
Added by stbuehler almost 6 years ago

Fix wrong lua type for CACHE_MISS/CACHE_HIT in mod_cml (fixes #533)

History

#1 Updated by jan about 8 years ago

  • Status changed from New to Fixed
  • Resolution set to wontfix

mod_cml is decreated in favour of mod_magnet in 1.4.12

#2 Updated by stbuehler about 6 years ago

  • Status changed from Fixed to Wontfix

#3 Updated by stbuehler almost 6 years ago

  • Status changed from Wontfix to Fixed
  • Pending set to No
  • Patch available set to No

Also available in: Atom