Lighttpd

I tried your patch, but I couldn't get lighttpd to compile with it. Here's the error I get:

libtool: link: gcc -g -O2 -Wall -W -Wshadow -pedantic -std=gnu99 -o lighttpd server.o response.o connections.o network.o configfile.o configparser.o request.o proc_open.o buffer.o log.o keyvalue.o chunk.o http_chunk.o stream.o fdevent.o stat_cache.o plugin.o joblist.o etag.o array.o data_string.o data_count.o data_array.o data_integer.o md5.o data_fastcgi.o fdevent_select.o fdevent_linux_rtsig.o fdevent_poll.o fdevent_linux_sysepoll.o fdevent_solaris_devpoll.o fdevent_freebsd_kqueue.o data_config.o bitset.o inet_ntop_cache.o crc32.o connections-glue.o configfile-glue.o http-header-glue.o network_write.o network_linux_sendfile.o network_freebsd_sendfile.o network_writev.o network_solaris_sendfilev.o network_openssl.o splaytree.o status_counter.o -Wl,--export-dynamic -L/usr/lib64 /usr/lib64/libpcre.so -ldl /usr/lib64/libfam.so -Wl,-rpath -Wl,/usr/lib64 -Wl,-rpath -Wl,/usr/lib64
connections.o: In function `connection_handle_read_state':
/mnt/progs/slack/test/lighttpd-1.4.26/src/connections.c:1200: undefined reference to `chunk_decoder_work'
/mnt/progs/slack/test/lighttpd-1.4.26/src/connections.c:1336: undefined reference to `chunk_decoder_free'
/mnt/progs/slack/test/lighttpd-1.4.26/src/connections.c:1283: undefined reference to `chunk_decoder_free'
/mnt/progs/slack/test/lighttpd-1.4.26/src/connections.c:1186: undefined reference to `chunk_decoder_create'
connections.o: In function `connection_reset':
/mnt/progs/slack/test/lighttpd-1.4.26/src/connections.c:806: undefined reference to `chunk_decoder_free'
connections.o: In function `connection_close':
/mnt/progs/slack/test/lighttpd-1.4.26/src/connections.c:127: undefined reference to `chunk_decoder_free'
collect2: ld returned 1 exit status
make³: *** [lighttpd] Error 1

FYI: recent patch to lighttpd will communicate to client 411 Length Required, so while Transfer-Encoding: chunked is still not supported, the server and client should behave better when the server sends 411 response.

commit 06d3c754403b2df99775641e05999ea9b2081618
Author: Glenn Strauss <gstrauss@gluelogic.com>
Date:   Sat Mar 26 12:58:33 2016 +0000

    [core] respond 411 Length Required if request has Transfer-Encoding: chunked (fixes #631)

    lighttpd does not currently support request body transfer-codings

    From: Glenn Strauss <gstrauss@gluelogic.com>

    git-svn-id: svn://svn.lighttpd.net/lighttpd/branches/lighttpd-1.4.x@3128 152afb58-edef-0310-8abb-c4023f1b3aa9

Any progress on this issue?

• webdav with lighttpd/php/sabredav
• OSX finder as client

This combinations results in PUT request with chunked encoding: http://sabre.io/dav/clients/finder/

I would offer extended testing, if a patch is provided.

FYI: a patch was provided for this feature a month ago, but no feedback was received. I added tests to the test suite and released the feature (Transfer-Encoding: chunked for HTTP request body, e.g. HTTP PUT)

Separately, a regression occurred in mod_webdav in lighttpd 1.4.43 which led to error trace in the log, and a different change turned this into a crashing bug in lighttpd 1.4.44. Now then, the bug is my fault, not yours, and I'll be adding tests to the test suite to attempt to avoid such mod_webdav issues in the future. Still, I am disappointed that I received no such feedback from you for either lighttpd 1.4.43 or lighttpd 1.4.44 after you seemed so eager for the new feature.

x-ref:
Lighttpd 1.4.43/44 dies - missing cleanup in webdav
https://redmine.lighttpd.net/boards/2/topics/7034

Sorry for not testing your patch, but OSX in newer versions does not use chunked PUT-request anymore.

I just tested some uploads, all PUT-requests are now with Content-Length. Tested with

server.stream-response-body = 1
server.stream-request-body = 0
server.reject-expect-100-with-417 = "disable" 

I do not see any 411 Length Required response.

server.stream-request-body = 0 

Verified now with OSX finder and

debug.log-request-header = "enable".

That should not be necessary after the patch in #2854 is released in lighttpd 1.4.49.

[Edit]: Correction: server.stream-request-body = 0 is needed with requests that send "Transfer-Encoding: chunked" since lighttpd will return "411 Length Required" before passing to backends, as the CGI spec requires setting CONTENT_LENGTH. mod_proxy is not a full HTTP/1.1 reverse proxy, and also returns 411 Length Required.

Applications like curl correctly handle 411 Length Required, and resend the request with Content-Length, e.g.
curl -T sample.txt -H "Transfer-Encoding: chunked" http://localhost:8080/cgi-bin/upload.pl

If you want server.stream-request-body enabled when "Content-Length" is set, but want to workaround when "Transfer-Encoding: chunked" is set, then use this in lighttpd.conf:

$REQUEST_HEADER["Content-Length"] == "" { server.stream-request-body = 0 }