Activity
From 2022-01-01 to 2022-01-07
2022-01-07
- 20:25 Bug #3134: mod_extforward plugin has out-of-bounds (OOB) write of 4-byte -1
- My testing on 32-bit ARM and on 64-bit ARM appears to have the same behavior as i686 (32-bit) and x86_64 (64-bit)
... - 07:30 Bug #3137: TRACEME environment option in tests broken with LISTEN_PID
- Those ideas are good, and I am considering others.
On (native) Windows, I may need a different solution to socket ... - 07:06 Revision 51e141c8: [multiple] remove buffer_init_buffer()
- remove (minor) convenience func; easy to replace
Like buffer_init_string(), buffer_init_buffer() was used in only a ... - 07:06 Revision bade1c03: [multiple] remove buffer_init_string()
- remove (minor) convenience func; easy to replace
- 07:06 Revision 10b307bd: [core] (const char *) for srvconf.modules_dir
- no need to be allocated (buffer *)
- 07:06 Revision e563ae01: [build] adjust help strings for pcre2 default
- 07:06 Revision 9fcb03b6: [mod_authn_gssapi] reduce KRB5CCNAME mem alloc
- reuse KRB5CCNAME path saved in r->env
request_reset() calls plugin cleanups (where KRB5CCNAME path unlinked)
before ... - 07:06 Revision 2e0b7cfb: [mod_authn_gssapi] code reuse: fdevent_mkostemp()
- 07:06 Revision e174e7df: [core] buffer_copy_string() use "" if s is NULL
- same for buffer_append_string()
- 00:30 Revision f6d6295a: [ci] add cmake-asan build type
2022-01-06
- 15:24 Revision ae2fb974: [array] use speaking names for array "fn" vtables for better debugging experience
- 15:24 Revision f3052d6a: [asan tests] fix memory leaks
- 15:23 Revision 61fa90bb: [cmake] add address/undefined sanitize compile options
- 14:49 Revision a0922351: [cmake] raise minimum version to 3.7
- cmake 3.7.0 was tagged on 2016-11-11
debian stretch (currentyl oldoldstable): 3.7.2
ubuntu bionic (18.04LTS): 3.10.2 - 14:02 Bug #3137 (Fixed): TRACEME environment option in tests broken with LISTEN_PID
- commit:5b1b9f78247e122804490b17112e94df32851464 switched to using (systemd) socket activation to pass an ephemeral li...
- 10:00 Revision 8ebe1c53: [lemon] silence coverity warnings
- 07:10 Feature #3136 (Fixed): haiku build fix proposal
- Applied in changeset commit:c0f040eae744e8688045d892d4fa150a7041a82b.
- 06:19 Feature #3136: haiku build fix proposal
- that ought to be the last "finding" in my side.
- 07:08 Bug #3134: mod_extforward plugin has out-of-bounds (OOB) write of 4-byte -1
- "emm." is a slang word for friendly
Thank you for the detailed analysis of this bug - 06:39 Bug #3134: mod_extforward plugin has out-of-bounds (OOB) write of 4-byte -1
- >> I have applied for a cve id, please trace
> What do you mean by "please trace"? Is that an incomplete sentence?
... - 07:03 Revision c0f040ea: [build] Haiku build fix (fixes #3136)
- Haiku needs to link to additional lib -lnetwork for socket funcs
(similar to Solaris need for -lsocket -lnsl)
(edite...
2022-01-05
- 23:34 Feature #3136: haiku build fix proposal
- lighttpd has not been tested on Haiku (https://www.haiku-os.org/about/) though I am happy to incorporate changes so t...
- 16:25 Feature #3136 (Fixed): haiku build fix proposal
- haiku build issues are fortunately all about network calls and linking them properly to the network system lib.
- 12:50 Bug #3134: mod_extforward plugin has out-of-bounds (OOB) write of 4-byte -1
- this is the new patch...
- 12:07 Bug #3134: mod_extforward plugin has out-of-bounds (OOB) write of 4-byte -1
- gstrauss wrote in #note-22:
> You did not include a commit message in the attachment. Please see the lighttpd git h... - 11:44 Bug #3134: mod_extforward plugin has out-of-bounds (OOB) write of 4-byte -1
- You did not include a commit message in the attachment. Please see the lighttpd git history for how I credit contrib...
- 11:34 Bug #3134: mod_extforward plugin has out-of-bounds (OOB) write of 4-byte -1
- I have applied for a cve id, please trace
- 11:31 Bug #3134: mod_extforward plugin has out-of-bounds (OOB) write of 4-byte -1
- patch: "0001-mod_extforward-fix-out-of-bounds-OOB-write-of-4-byte.patch"
you can call me "povcfe" and I would like t... - 10:47 Bug #3134: mod_extforward plugin has out-of-bounds (OOB) write of 4-byte -1
- Yes, for systems and distros which enable the canary by default, and if the prerequisites to reach the bug are met, t...
- 10:13 Bug #3134: mod_extforward plugin has out-of-bounds (OOB) write of 4-byte -1
- gstrauss wrote in #note-17:
> >> This is a bug and the bug has been acknowledged. I am not sure what your posts are ... - 10:07 Bug #3134: mod_extforward plugin has out-of-bounds (OOB) write of 4-byte -1
- >> This is a bug and the bug has been acknowledged. I am not sure what your posts are trying to say beyond that.
>... - 09:45 Bug #3134: mod_extforward plugin has out-of-bounds (OOB) write of 4-byte -1
- gstrauss wrote in #note-15:
> > Please respect contributors who find problems and submit patches
>
> I appreciate... - 09:35 Bug #3134: mod_extforward plugin has out-of-bounds (OOB) write of 4-byte -1
- > Please respect contributors who find problems and submit patches
I appreciate that you have taken the time to fi... - 09:21 Bug #3134: mod_extforward plugin has out-of-bounds (OOB) write of 4-byte -1
- povcfe-bug wrote in #note-12:
> gstrauss wrote in #note-11:
> > This is a bug and the bug has been acknowledged. I... - 09:19 Bug #3134: mod_extforward plugin has out-of-bounds (OOB) write of 4-byte -1
- gstrauss wrote in #note-11:
> This is a bug and the bug has been acknowledged. I am not sure what your posts are tr... - 09:16 Bug #3134: mod_extforward plugin has out-of-bounds (OOB) write of 4-byte -1
- gstrauss wrote in #note-11:
> This is a bug and the bug has been acknowledged. I am not sure what your posts are tr... - 09:13 Bug #3134: mod_extforward plugin has out-of-bounds (OOB) write of 4-byte -1
- This is a bug and the bug has been acknowledged. I am not sure what your posts are trying to say beyond that.
My ... - 09:00 Bug #3134: mod_extforward plugin has out-of-bounds (OOB) write of 4-byte -1
- !header.png!
- 08:57 Bug #3134: mod_extforward plugin has out-of-bounds (OOB) write of 4-byte -1
- gstrauss wrote in #note-8:
> > So compiling 32-bit lighttpd within an operating system with a higher gcc version, or... - 08:50 Bug #3134: mod_extforward plugin has out-of-bounds (OOB) write of 4-byte -1
- > So compiling 32-bit lighttpd within an operating system with a higher gcc version, or compiling and using lighttpd ...
- 08:29 Bug #3134: mod_extforward plugin has out-of-bounds (OOB) write of 4-byte -1
- So compiling 32-bit lighttpd within an operating system with a higher gcc version, or compiling and using lighttpd wi...
- 08:25 Bug #3134: mod_extforward plugin has out-of-bounds (OOB) write of 4-byte -1
- povcfe-bug wrote in #note-5:
> gstrauss wrote in #note-3:
> > You are correct that there is an out-of-bounds write ... - 08:19 Bug #3134: mod_extforward plugin has out-of-bounds (OOB) write of 4-byte -1
- gstrauss wrote in #note-3:
> You are correct that there is an out-of-bounds write on the stack.
> However, this out... - 08:14 Bug #3134 (Patch Pending): mod_extforward plugin has out-of-bounds (OOB) write of 4-byte -1
- You are correct that there is an out-of-bounds write on the stack.
However, this out-of-bounds write is not controlle... - 05:40 Bug #3134: mod_extforward plugin has out-of-bounds (OOB) write of 4-byte -1
- I uploaded the exp by mistake, please delete it in time
- 05:12 Bug #3134 (Fixed): mod_extforward plugin has out-of-bounds (OOB) write of 4-byte -1
- h2. 1. OOB write reproduce(lighttpd-1.4.46-1.4.63)
> The OOB write covers lighttpd-1.4.46-1.4.63
h3. 1.1 lightt... - 12:48 Feature #3135: server.core-files support on Solaris based system
- your last changes work for me.
- 12:35 Feature #3135 (Fixed): server.core-files support on Solaris based system
- Applied in changeset commit:b6bd11c15e62133426cf2acf189886237b97736c.
- 12:32 Feature #3135 (Patch Pending): server.core-files support on Solaris based system
- Probably overthinking it. If it helps, great. If it does not, then things are the same as they were before.
- 12:15 Feature #3135: server.core-files support on Solaris based system
- FYI with this basic hello world...
- 11:50 Feature #3135: server.core-files support on Solaris based system
gstrauss wrote in #note-4:
> Thanks for the pointer to an example. Should this patch check the return value...- 10:40 Feature #3135: server.core-files support on Solaris based system
- should be fine. In openssh case it s important they check since they want to make sure it can't be traced while here ...
- 10:37 Feature #3135: server.core-files support on Solaris based system
- Thanks for the pointer to an example. Should this patch check the return value from @setpflags()@? Should lighttpd ...
- 09:59 Feature #3135: server.core-files support on Solaris based system
- Indeed it is not documented it is a known feature tough when you get to do solaris native programming, one of the few...
- 09:54 Feature #3135: server.core-files support on Solaris based system
- What is @__PROC_PROTECT@? It is not mentioned in any of
https://www.illumos.org/man/5/privileges
https://www.illum... - 08:34 Feature #3135: server.core-files support on Solaris based system
- ought to be my last solaris patch.
- 08:34 Feature #3135 (Fixed): server.core-files support on Solaris based system
- - based on personal/gstrauss/master branch.
- basically making the current process traceable via setpflags call and ... - 12:35 Bug #3132 (Fixed): Solaris little nit build fix and startup fix
- Applied in changeset commit:3d0f64894823476165b7b31d5a508899cbfe2bec.
- 09:04 Bug #3132: Solaris little nit build fix and startup fix
- gstrauss wrote in #note-10:
> > Question since in the root CMakeLists.txt you set CMAKE_C_STANDARD, is the cmake_min... - 08:43 Bug #3132: Solaris little nit build fix and startup fix
- your last version works for me.
- 08:03 Bug #3132: Solaris little nit build fix and startup fix
- > Question since in the root CMakeLists.txt you set CMAKE_C_STANDARD, is the cmake_minimum_required set to 2.8.2 stil...
- 06:58 Bug #3132: Solaris little nit build fix and startup fix
- https://cmake.org/cmake/help/latest/variable/CMAKE_C_STANDARD.html
- 06:58 Bug #3132: Solaris little nit build fix and startup fix
- Little mistake from my part, CMAKE_REQUIRED_LIBRARIES is a list of then it is
set(CMAKE_REQUIRED_LIBRARIES "socket... - 00:30 Bug #3132 (Patch Pending): Solaris little nit build fix and startup fix
- 00:04 Bug #3132: Solaris little nit build fix and startup fix
- > ah I see, not visible if you re using the web UI but if you download the file you can see normally (I commit locall...
- 12:35 Bug #3133 (Fixed): netbsd meson build fix
- Applied in changeset commit:94a16b2b53e797fdaeed06e2bcc7caffb634bad1.
- 12:35 Feature #3131 (Fixed): Remove unneeded connection bsd filter handling for OpenBSD
- Applied in changeset commit:7eac25ac7f69107448ecd59d5a6b40b2f61d8bc2.
- 12:35 Feature #3130 (Fixed): Solaris build fix proposal
- Applied in changeset commit:b9d58fa723cd3789b8fb2475696a7c596fefc961.
- 01:21 Feature #3130: Solaris build fix proposal
- The patch for @-Wl,-export-dynamic@ needs adjustment, as it breaks when clang is used instead of gcc. I might add a ...
- 12:28 Revision 1b11cd7a: [build] feature consistency between build types
- 11:52 Revision b6bd11c1: [core] server.core-files support for solaris (fixes #3135)
- server.core-files support for solaris based systems.
- using setpflags and disable process tracing protection for th... - 08:02 Revision 3d0f6489: [core] /dev/null is a symlink on Illumos (fixes #3132)
- (thx devnexen)
also fix IPv6 detection on Illumos in CMake
x-ref:
"Solaris little nit build fix and startup fix"
... - 02:27 Revision 94a16b2b: [build] meson crypt and dl detection on *BSD (fixes #3133)
- (thx devnexen)
x-ref:
"netbsd meson build fix"
https://redmine.lighttpd.net/issues/3133 - 02:27 Revision fa1ee081: [build] adjust .gitignore for macOS
- 02:27 Revision f72de711: [build] cmake: skip "-Wl,-export-dynamic" Illumos
- (thx devnexen)
cmake: do not pass "-Wl,-export-dynamic" to Sun ld on Illumos
x-ref:
"Solaris build fix proposal"
... - 02:27 Revision d6741c58: [build] meson misdetects mempcpy on some platforms
- (thx devnexen)
x-ref:
"Meson misdetects some functions with mingw-w64"
https://github.com/mesonbuild/meson/issue... - 02:27 Revision e3c3f271: [mod_webdav] define HAVE_RENAMEAT2 earlier
- (including linux/fs.h later might reveal RENAME_NOREPLACE)
- 02:27 Revision 0c22c643: [mod_webdav] copy acceleration
- * copy acceleration
* safety for accelerated copying of files > 2 GB on 32-bit systems
* disable hard linking when "d...
2022-01-04
- 22:59 Bug #3132: Solaris little nit build fix and startup fix
- ah I see, not visible if you re using the web UI but if you download the file you can see normally (I commit locally ...
- 22:56 Bug #3132: Solaris little nit build fix and startup fix
- > - commit message explaining the reasonings but expaning a bit.
BTW, I don't know where you are committing things, ... - 22:35 Bug #3132: Solaris little nit build fix and startup fix
- ...
- 22:15 Bug #3132: Solaris little nit build fix and startup fix
- > At startup, lighttpd after parsing the config, does not start, happening while trying to open the /dev/null device
... - 22:06 Bug #3132: Solaris little nit build fix and startup fix
- Please provide @ls -l /dev/null@ (and the resulting chain) on Illumos, for inspection.
The unrelated patch for an ... - 15:09 Bug #3132 (Fixed): Solaris little nit build fix and startup fix
- - this time, based on personal/gstrauss/master branch
- commit message explaining the reasonings but expaning a bit.... - 22:52 Bug #3133: netbsd meson build fix
- your fix works for me
- 22:03 Bug #3133 (Patch Pending): netbsd meson build fix
- Turns out there are some issues with meson detection and confusion with builtins, which for some compilers are always...
- 19:22 Bug #3133: netbsd meson build fix
- note that openbsd ought to have same cases :
- no mempcpy support.
- crypt having same header https://man.openbsd.o... - 19:07 Bug #3133 (Fixed): netbsd meson build fix
- - this is a pure meson issue, cmake and autoconf builds work fine.
- mostly little misdetections.
- patch done out ... - 09:33 Feature #3130: Solaris build fix proposal
- meson build passes now, cheers.
- 09:30 Feature #3130: Solaris build fix proposal
- Ok. Those should be fixed, too, on my dev branch except for printf of pid_t warnings, which will be addresses some t...
- 09:22 Feature #3130: Solaris build fix proposal
- cmake we re good now.
meson same little linkage issue as cmake... - 09:14 Feature #3130: Solaris build fix proposal
- Force pushed fixes to my branch.
Yes, it makes more sense to limit @-Wl,-export-dynamic@ to @... AND CMAKE_C_COMPILE... - 09:05 Feature #3130: Solaris build fix proposal
- happens that s fine :-)
little nits, cmake ... - 08:48 Feature #3130: Solaris build fix proposal
- My sincerest apologies for all those typos in meson.build. I have force-pushed fixes to my dev branch.
I also think... - 08:02 Feature #3130: Solaris build fix proposal
- with cmake ...
- 01:07 Feature #3130: Solaris build fix proposal
- Please check your build environments.
* lighttpd-angel.c includes first.h, which defines @__EXTENSIONS__@ when @__sun... - 09:25 Revision 8b38a6eb: [core] errno_t and rsize_t detection on Illumos
- (thx devnexen)
- 09:25 Revision 7eac25ac: [core] hide bsd_accept_filter code on OpenBSD (fixes #3131)
- (thx devnexen)
OpenBSD does not provide SO_ACCEPTFILTER
(This patch shows a good example of why cuddled-else should... - 09:25 Revision b9d58fa7: [build] cmake,meson socket libs for win32, Illumos (fixes #3130)
- (thx devnexen)
cmake, meson: specify socket libs for win32, Illumos
x-ref:
"Solaris build fix proposal"
https:/... - 09:25 Revision a931b1fc: [core] define __EXTENSIONS__ on Illumos
- (thx devnexen)
- 08:22 Revision 7ead5618: [build] meson: find pcre2 w/o pkg-config
- meson: find pcre2 on Illumos w/o pkg-config
2022-01-03
- 21:49 Feature #3130: Solaris build fix proposal
- with cmake :...
- 21:31 Feature #3130 (Patch Pending): Solaris build fix proposal
- 21:20 Feature #3130: Solaris build fix proposal
- *untested* patches are on my dev branch https://git.lighttpd.net/lighttpd/lighttpd1.4/src/branch/personal/gstrauss/ma...
- 19:23 Feature #3130: Solaris build fix proposal
- Something similar might be needed in src/lighttpd-angel.c and tests/{fcgi,scgi}-responder.c...
- 10:21 Feature #3130: Solaris build fix proposal
- The meson configure part does not pass, it stop at pcre/pcre2 detection (do not know if it relies on pkg-config, but ...
- 09:51 Feature #3130: Solaris build fix proposal
- Does linking @-lsocket -lnsl@ work on Illumos with the meson build?
I've pushed some commits for small items. I'l... - 09:19 Feature #3130: Solaris build fix proposal
- - The order of linkage does not matter it passes.
- for the std=gnu99 removal it seems it had been switched to C11 b... - 09:11 Feature #3130: Solaris build fix proposal
- Please provide compiler error messages. The errno_t patch to ck.h is fine. I have questions for the rest.
A long... - 09:07 Feature #3130: Solaris build fix proposal
- if you wonder why the change for the HAVE_SYS_LOADAVG_H detection, the detection failed because loadavg struct used t...
- 08:56 Feature #3130: Solaris build fix proposal
- - Illumos but the linkage issues are the same on Solaris too.
- from master branch.
- Linkage and errno_t availabil... - 08:49 Feature #3130: Solaris build fix proposal
- Please do not spit patches without context.
What is your test platform and version of Solaris? What lighttpd comm... - 08:24 Feature #3130 (Fixed): Solaris build fix proposal
- 21:32 Feature #3131 (Patch Pending): Remove unneeded connection bsd filter handling for OpenBSD
- 18:52 Feature #3131 (Invalid): Remove unneeded connection bsd filter handling for OpenBSD
- >> What is the impact?
Impact is zero. Modern compiler optimizers will remove the empty code block on OpenBSD, as... - 18:14 Feature #3131: Remove unneeded connection bsd filter handling for OpenBSD
- Because it is not a new feature.
Thinking of it maybe surrounding the whole block by SO_ACCEPTFILTER instead of th... - 17:57 Feature #3131: Remove unneeded connection bsd filter handling for OpenBSD
- Why was this filed as a bug? What is the impact?
If OpenBSD does not define SO_ACCEPTFILTER, then the rest of the... - 16:37 Feature #3131 (Fixed): Remove unneeded connection bsd filter handling for OpenBSD
- - Just a little nit ; OpenBSD is the only main BSD not supporting accept filter on sockets.
- Edited from master bra... - 09:31 Revision 0aa6f735: [build] cmake build now defaults to C11
- cmake build now defaults to C11, like meson build
- 09:29 Revision b9706ac4: [core] errno_t detection on Illumos
- (thx devnexen)
- 09:25 Revision 2c391746: [build] update tests/SConscript
- 08:08 Revision 9abc08d7: [build] adjust trace for regex-conditionals
- adjust trace for regex-conditionals features to include pcre and pcre2
- 07:28 Revision d5872659: [core] "server.graceful-shutdown-timeout" => 8
- default "server.graceful-shutdown-timeout" => 8
previous default 0; disabled, so infinite timeout
configure previous... - 07:28 Revision 750414d3: [build] default --with-pcre2 unless --with-pcre
- 07:28 Revision 86c2d309: [multiple] remove long-deprecated modules
- x-ref:
https://wiki.lighttpd.net/Docs_ConfigurationOptions#Deprecated - 07:25 Feature #3129 (Fixed): rand macOs case handling update
- Applied in changeset commit:1334dd4ad52f8685948066af4798446af6b3e2da.
- 07:23 Revision 1334dd4a: [core] CCRandomGenerateBytes() for rand on macOS (fixes #3129)
- (thx devnexen)
x-ref:
"rand macOs case handling update"
https://redmine.lighttpd.net/issues/3129 - 06:42 Revision c5d55a99: [build] cmake build now defaults to C11
- cmake build now defaults to C11, like meson build
- 06:42 Revision c7c34201: [build] feature consistency between build types
- upate config.h.cmake for missing defines
minor adjustments to other builds for features consistency
2022-01-02
- 23:09 Feature #3129: rand macOs case handling update
- your patch works for me.
- 21:13 Feature #3129: rand macOs case handling update
- I consider the following *untested* patch to be better encapsulated and easier to read. Only because it is encapsula...
- 12:52 Feature #3129: rand macOs case handling update
- this function pointer returns 0 on success, now the vast majority of time it does not fail indeed and the buffers at ...
- 12:36 Feature #3129: rand macOs case handling update
- @CCRandomGenerateBytes()@ seems to be based on @ccrng@ (which is also used by the @arc4random@ code): https://www.nia...
- 11:08 Feature #3129: rand macOs case handling update
- pb with arc4random you cannot know if it failed. otherwise we can always open /dev/urandom but might be heavyweight f...
- 11:04 Feature #3129: rand macOs case handling update
- Fair enough
[[https://opensource.apple.com/source/Libc/Libc-1439.40.11/gen/FreeBSD/arc4random.c.auto.html]]
... - 10:49 Feature #3129: rand macOs case handling update
- I think it falls back to @random()@...
The justification should include what the failure conditions of @CCRandomGe... - 10:34 Feature #3129: rand macOs case handling update
- Citations and references, please.
If lighttpd is linked against any crypto library, you can see that lighttpd prefer... - 09:56 Feature #3129 (Fixed): rand macOs case handling update
- - using new api instead of arc4random when possible (from Yosemite).
- fixing cmake build for other cases. - 09:31 Feature #3128 (Fixed): server.core-files support on FreeBSD proposal
- That is what I posted 8 comments ago, which took you more than a few tries to properly add to your build and compile.
- 08:57 Feature #3128: server.core-files support on FreeBSD proposal
- ...
- 08:56 Feature #3128: server.core-files support on FreeBSD proposal
- hold on, it passes. :-)
- 08:54 Feature #3128: server.core-files support on FreeBSD proposal
- this last patch still triggers the same issue with _ISOC11_SOURCE definition...
- 08:51 Feature #3128: server.core-files support on FreeBSD proposal
- Are you testing with this patch?...
- 08:44 Feature #3128: server.core-files support on FreeBSD proposal
- I wrote in same time than your last comment so we agree on a point at least.
- 08:42 Feature #3128: server.core-files support on FreeBSD proposal
- So with your suggestion still same issues mentioned above unfortunately, this time I show you what the compiler/linke...
- 08:40 Feature #3128: server.core-files support on FreeBSD proposal
- Bug in my patch: @#ifdef HAVE_COPY_FILE_RANGE /* FreeBSD 13+ */@ will not be true before @#include "first.h"@, so I n...
- 08:36 Feature #3128: server.core-files support on FreeBSD proposal
- Please try the change to @+#define _ISOC11_SOURCE 1@ below....
- 08:26 Feature #3128: server.core-files support on FreeBSD proposal
- If I remove the _ISOC11_SOURCE definition it passes...
- 08:25 Feature #3128: server.core-files support on FreeBSD proposal
- Yes true, the copy_file_range code use it s wrapped in this way. I use cmake.
So with the actual code I get
... - 08:15 Feature #3128: server.core-files support on FreeBSD proposal
- The code in mod_webdav which uses @copy_file_range()@ is wrapped in @#ifdef HAVE_COPY_FILE_RANGE@.
@HAVE_COPY_FILE_R... - 07:35 Feature #3128: server.core-files support on FreeBSD proposal
- Sorry again, I will be more careful next time.
- 07:33 Feature #3128: server.core-files support on FreeBSD proposal
- Fair point.
So I reclone your repo and. branch and with... - 07:23 Feature #3128 (Reopened): server.core-files support on FreeBSD proposal
- 07:18 Feature #3128: server.core-files support on FreeBSD proposal
- > well the second version, _XOPEN_SOURCE is already defined. but fine otherwise.
I don't think you and I understan... - 06:59 Feature #3128: server.core-files support on FreeBSD proposal
- Alternatively, if you really want to keep on HAVE_COPY_FILE_RANGE, you can replace by something along those lines
<pr... - 06:53 Feature #3128: server.core-files support on FreeBSD proposal
- After a full clean compile I get the error finally.
So what I gather :
- HAVE_COPY_FILE_RANGE can t be defined where... - 00:25 Feature #3128 (Fixed): server.core-files support on FreeBSD proposal
- Applied in changeset commit:f36908de33c60f6cca3a6ae8be625d8f25e1c7ac.
- 00:02 Feature #3128: server.core-files support on FreeBSD proposal
- well the second version, _XOPEN_SOURCE is already defined. but fine otherwise.
- 08:43 Revision d8bceb14: [mod_webdav] copy_file_range() new in FreeBSD 13
- (take 2)
adjust feature defines for header visibility of copy_file_range()
(introduced in FreeBSD 13)
x-ref:
http... - 00:09 Revision 5567fb64: [mod_webdav] copy_file_range() new in FreeBSD 13
- (thx devnexen)
adjust feature defines for header visibility of copy_file_range()
(introduced in FreeBSD 13)
x-ref:
...
2022-01-01
- 23:30 Revision 8e1ad363: [mod_webdav] detect truncated copy_file_range()
- detect truncated file when using copy_file_range(), even though
this should not happen with lighttpd-created temporar... - 23:24 Feature #3128: server.core-files support on FreeBSD proposal
- This is probably more future-proof:...
- 23:12 Feature #3128: server.core-files support on FreeBSD proposal
- https://github.com/freebsd/freebsd-src/blob/main/sys/sys/cdefs.h#L740
If @_C99_SOURCE@ is the issue for you due to bu... - 22:49 Feature #3128: server.core-files support on FreeBSD proposal
- > All good except the copy_file_range fix being not present
Not forgotten, but not related to this issue: "server.... - 21:59 Feature #3128: server.core-files support on FreeBSD proposal
- All good except the copy_file_range fix being not present, I got the compile warning.
Indeed for dragonfly I meant i... - 21:48 Feature #3128 (Patch Pending): server.core-files support on FreeBSD proposal
- 21:44 Feature #3128: server.core-files support on FreeBSD proposal
- Your comment about DragonFlyBSD is unclear.
I think you meant to say more directly -- instead of to imply -- that Dra... - 21:24 Feature #3128: server.core-files support on FreeBSD proposal
- I see that you added @#include <sys/procctl.h>@. Good. That was missing in earlier patches, too.
- 20:56 Feature #3128: server.core-files support on FreeBSD proposal
- ah; in a first iteration of the patch I set with only one `C` and forgot to correct afterwards and the previous updat...
- 20:47 Feature #3128: server.core-files support on FreeBSD proposal
- Thanks for the updated patch. Have you tested the patches? (either the old or the new?)
@#if defined(HAVE_SYS_PRO... - 19:25 Feature #3128: server.core-files support on FreeBSD proposal
- Here a new version of the patch w/o the useless changes.
- 19:13 Feature #3128: server.core-files support on FreeBSD proposal
- Yes, I can adapt your patch. Still, please verify local git repo from which you created your patch.
https://github.c... - 18:58 Feature #3128: server.core-files support on FreeBSD proposal
- Unfortunately the _BSD_SOURCE solution did not work out (I tried already anyway).
about the code source discrepancy,... - 18:21 Feature #3128: server.core-files support on FreeBSD proposal
- What commit or tag is your patch against? There seems to be some excess added lines which are already present in lig...
- 11:00 Feature #3128 (Fixed): server.core-files support on FreeBSD proposal
- 22:40 Revision 5b310b36: [mod_extforward] support longer PROXY v2 TLV vec
- support longer HAProxy PROXY protocol v2 TLV vector
(allow up to 2k total for header + TLVs, saved on stack,
and exp... - 21:54 Revision f36908de: [core] server.core-files support on FreeBSD (fixes #3128)
- (thx devnexen)
x-ref:
"server.core-files support on FreeBSD proposal"
https://redmine.lighttpd.net/issues/3128 - 21:25 Revision 2fc6e113: [build] do not check for prctl; HAVE_PRCTL unused
Also available in: Atom